You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 15 Next »

The following sections provide guidance on how to review a release PR / issue.

Please add questions as you come across them in the respective sections and add comments/text for answering them.

Review issues and process

  • Who can approve the M3 release PR ? Code Owners after RM approval is noted in the release PR or its issue. 
  • When to create a RM review issue ? when the release-management_maintainers list is included as a reviewer in a release PR. After creating a review issue 
  • When do I tick a review issue task ?
    • Review actions: tick after checking the related file(s) and putting the review comment(s) in the PR/PR issue about the(se) files. Also put just OK for the file if no comments.
    • Also put a comment on the reveiw issue istemlf about the major review comments and the overall state of the API.
    • Release actions: tick when task is done.
  • When do we close the review issue ? When all 11 tasks in the issue are ticked as done. Close as completed 
  • Question: should we add an "M3" milestone label so we can filter on it later ? 
  • How to know if an APIs is covered by RM ?  Need to test on the Meta-release page.

Review actions

API definition files (YAML) (check version in info & servers objects)

  • Check Info object
    • version: aligned with the released API version and formatted correctly (per Commonalities)
    • description:
      • contains sufficient in-line API documentation
      • does not use Telco Jargon / abbreviations (non blocking for release if in docuemntation)
      • contains the section on auth from ICM - issue to put on ICM backlog - apply for next meta-release to API specs Herbert Damker to check with ICM team.
    • presence of the x-camara-commonalities: 0.4.0
  • Check servers object has the correct version format e.g. v0.xrc1 or v1rc1
  • Check security schemes: check presence and format (OIDC) and scope name format.
  • Is there a way to know if an API requires consent request ? No, this is local regulation. It is covered when using the security scheme and the scope rules.
  • In externalDocs: this filed is optional, but recommend to point to the CAMARA, repo.
      description: Project documentation at CAMARA
      url: https://github.com/camaraproject/<repo>
  • Shall error cases be explained in in-line documentation ? (info.description) It seems yes as per Commonalities/documentation/API-DocumentationTemplate.md - Deprecate the doc and doc shall be inline in OAS spec. @Rafal to updater in Commonalities

test file(s) availability

  • should the test file contain the version number ? e.g. Feature: CAMARA Call Fowarwing Signal  API, v0.1.0 - Operation call-forwardings - is it required to include the version (as people forget to update it). As the tests are in the same release package, can the version number be avoided in the test features ?
  • all error codes shall be covered by final test scenarios. what do we consider the main error cases for rc ? 
  • can we automate checking that all API spec errors/cases are covered by the tests ?

changelog updated

  • Comment: For capturing changes, its is recommended to use the GitHub release feature to get the list of all the changes which can then be selected as appropriate and put in the right categorie (added, changed etc) - ask a GitHub expert how to do this by creating a draft release (guidelines are WIP).

readme updated (enforce correct release number / API version naming)

  • enforce the correct release number / API version naming

API readiness checklist(s)

  • API definition files
  • commonalities
    • availability of linting report in release issue (tbc)
  • ICM
  • versioning (checked in yaml)
  • documentation (beyond in-line)
    • check for Telco jargon / abbeviations
  • user stories
  • basic test files (for M3)
    • is it necessary for a Feature to reference the API version ? as it is anyway in the same release package ? 
    • cover 200 response and all error responses (tbc)
  • enhanced test files (for M4)
    • all all error responses shall be covered by M4 
    • add guideline to use error codes in scenario names ?
  • release numbering
  • changelog
  • certification - for stable public APIs

Re-usable review comment texts

  • if you see a release PR that is nearly ready, add a comment as follows: "Please add @release-management_maintainers to this PR once the PR is ready"
  • for final approval use a comment: "LGTM from ReleaseManagement."

Release actions

  • Tick task when checked and done.
  • When all tasks are ticked, close review issue with a comment on the overall status of the API as applicable.


  • No labels